Mcore dist opt ckpt fix #9156
Merged
Mcore dist opt ckpt fix #9156
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoumpa
force-pushed
the
akoumparouli/mcore_dist_opt_ckpt
branch
from
28b6376
to
be23a09
Compare
akoumpa
force-pushed
the
akoumparouli/mcore_dist_opt_ckpt
branch
from
be23a09
to
b1df810
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
akoumpa
force-pushed
the
akoumparouli/mcore_dist_opt_ckpt
branch
from
dcd692e
to
cb78ce9
Compare
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/mcore_dist_opt_ckpt
branch
from
00f478e
to
545fc51
Compare
Signed-off-by: akoumpa <[email protected]>
akoumpa
force-pushed
the
akoumparouli/mcore_dist_opt_ckpt
branch
from
4643470
to
a2d516c
Compare
mikolajblaz
reviewed
May 17, 2024
… ckpt Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/mcore_dist_opt_ckpt
branch
from
a2d516c
to
8fa988d
Compare
Signed-off-by: akoumpa <[email protected]>
mikolajblaz
reviewed
May 21, 2024
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: akoumpa <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
mikolajblaz
reviewed
May 22, 2024
dimapihtar
previously approved these changes
May 22, 2024
Co-authored-by: mikolajblaz <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
mikolajblaz
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Enable saving/restoring checkpoint when using mcore dist opt in NeMo.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information