Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Refactor cicd-main #9126

Closed
wants to merge 1 commit into from
Closed

ci: Refactor cicd-main #9126

wants to merge 1 commit into from

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented May 7, 2024

What does this PR do ?

Split our testsuite into smaller chunks and DRY our cicd-main workflow file.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@ko3n1g ko3n1g added the Run CICD label May 7, 2024
@github-actions github-actions bot added the CI label May 7, 2024
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels May 7, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/refactor/nemo-cicd branch from dc3fd18 to 616123c Compare May 7, 2024 13:28
@ko3n1g ko3n1g changed the title wip ci: Refactor cici-main May 7, 2024
@ko3n1g ko3n1g requested a review from pablo-garay May 7, 2024 13:30
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels May 7, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/refactor/nemo-cicd branch from 616123c to 41f322d Compare May 7, 2024 13:32
@ko3n1g ko3n1g changed the title ci: Refactor cici-main ci: Refactor cicd-main May 7, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/refactor/nemo-cicd branch 2 times, most recently from b38e6e1 to 26e4228 Compare May 7, 2024 13:39
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels May 7, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/refactor/nemo-cicd branch from 26e4228 to c15baef Compare May 7, 2024 13:41
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels May 7, 2024
@ko3n1g ko3n1g marked this pull request as ready for review May 7, 2024 13:43
@ko3n1g ko3n1g closed this May 13, 2024
@ko3n1g ko3n1g deleted the ko3n1g/refactor/nemo-cicd branch May 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant