[torch2trt/converters] Add element support to torch.Tensor.__getitem__ converter
#770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoz-dev
changed the title
torch.Tensor.__getitem_ convertertorch.Tensor.__getitem__ converter
|
Note that this was tested on v0.3.x; the unit tests here fail on v0.4.0. See #769. |
|
Running |
chaoz-dev
force-pushed
the
chaoz/getitem-element
branch
from
c91f166
to
7a968cc
Compare
chaoz-dev
force-pushed
the
chaoz/getitem-element
branch
from
7a968cc
to
dd49b3e
Compare
chaoz-dev
commented
Nov 21, 2022
Comment on lines
+192
to
+196
| # There is currently an issue with this test case. | ||
| # Need to investigate this more. | ||
| # @add_module_test(torch.float32, torch.device('cuda'), [(3, 2, 4)], max_batch_size=3) | ||
| # def test_tensor_getitem_0d_3tuple(): | ||
| # return LambdaModule(lambda x: x[(0, 1, 2)]) |
There was a problem hiding this comment.
@jaybdub Looks like there's an issue with this test case, which we'll need to look into more. I don't think it's related to the changes in this PR, however, but with how we're indexing in general.
ie. I believe this was passing on the v0.4.0 release with static shapes, but does not appear to be passing now on latest master.
|
…etitem__ converter.
chaoz-dev
force-pushed
the
chaoz/getitem-element
branch
from
87a7ada
to
2b03dbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #768.
This PR adds support for single element arguments to
torch.Tensor.__getitem__converter.We convert the input into a tuple if it is not already a tuple, which can occur when the input argument is a single argument. All other arguments should be handled the same (especially multiple arguments, as they are already tuples).
Single tuple arguments are unpacked correctly still as expected into multiple indexing arguments.
Note that tuples combined with ellipsis or colon arguments are still not yet supported; see #755.
Also, add a lot of unit tests to check that operations on the batch dimension are handled correctly.