Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese #1157

Merged
merged 2 commits into from
May 31, 2024
Merged

Add Chinese #1157

merged 2 commits into from
May 31, 2024

Conversation

ra5pvt1n
Copy link
Contributor

Add translations for Simplified Chinese and Traditional Chinese.

From README.md

When creating a new language file ensure it follows the ISO 639 2-letter standard

Since scripts for both Simplified Chinese and Traditional Chinese share the same ISO 639 2-letter standard code (zh), I've provisionally named them as hans.json for Simplified Chinese and hant.json for Traditional Chinese in order to distinguish between them.

A better way to name these files can be discussed.

See also How should the language codes be formatted? from i18next FAQ

add hans.json and hant.json to public/i18n
provisionally add simplified and traditional chinese to languages.ts
Copy link
Collaborator

@futurepaul futurepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wonderful, thank you so much!

@futurepaul futurepaul merged commit b99fb27 into MutinyWallet:master May 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants