Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced hierarchical sorting. #410

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

keyboardDrummer
Copy link

DONE:

  • hierarchical sorting on a regular widgetless table.
  • fixed the widgets when you're not using hierarchical sorting.

TODO:

  • Make the css classes used to define the hierarchy customisable.
  • Test/define/implement how the widgets work when you're using the hierarchy.

Example: http://steenreem.github.io/tablesorter/docs/example-tree-table.html

@thezoggy
Copy link
Collaborator

thezoggy commented Nov 8, 2013

have a screen shot or demo of this up anywhere?

@keyboardDrummer
Copy link
Author

Here an example: http://keyboarddrummer.github.io/tablesorter/docs/example-tree-table.html

@Mottie
Copy link
Owner

Mottie commented Nov 9, 2013

Doh, I broke the auto merge... oh well. I'll start looking at your work for the next update :)

Thanks again for all your hard work.

@Mottie
Copy link
Owner

Mottie commented Nov 16, 2013

Hey Remy!

Sorry, I've been too busy with other projects and minor updates that I haven't gotten around to incorporating this enhancement.

I've been considering adding this as an extension instead of incorporating it into the core since it makes changes to the cache, and the work I have locally for the upcoming version 3 also significantly changes the cache.

@keyboardDrummer
Copy link
Author

So where's the code for version 3? Is that the development branch? I could
also apply my commits based off of your development branch.

On Sun, Nov 17, 2013 at 12:37 AM, Rob G [email protected] wrote:

Hey Remy!

Sorry, I've been too busy with other projects and minor updates that I
haven't gotten around to incorporating this enhancement.

I've been considering adding this as an extension instead of incorporating
it into the core since it makes changes to the cache, and the work I have
locally for the upcoming version 3 also significantly changes the cache.


Reply to this email directly or view it on GitHubhttps://github.com//pull/410#issuecomment-28638685
.

@Mottie
Copy link
Owner

Mottie commented Nov 19, 2013

Hey Remy!

The version 3 code I've been working on, I only have locally... and it hasn't been updated with all the changes made recently 😒

The development branch was needed to make a version of the plugin that would work with Zepto... I'll try to update the development branch more in the future to more closely match what I have done in version 3. Sorry, it's been really slow going for me - finding time, motivation and no other distractions :P

@michaelh99
Copy link

Was this ever merged anywhere else or is this a dead PR?

@Mottie
Copy link
Owner

Mottie commented Mar 25, 2016

Hi @michaelh99!

It's not dead. It's still open for reference. This won't get integrated until after this fork of tablesorter gets rewritten, and renamed to Abelt - I just need more free time 😞.

@ronibduk
Copy link

ronibduk commented Sep 2, 2016

Hi @michaelh99!

I am nearly new in JQuery and trying to use hierarchical sorting in my project. Unfortunately, sorting only working on the parent rows not the child rows. I have followed what is described here. But no luck. I followed the following steps for hierarchical sorting -
Included jquery.treetable.js file
Added -

$(".tablesorter")
        .tablesorter({
            theme : 'blue'
        })      
        .treetable({ expandable: true});

And my parent rows have class data-tt-id and child rows have class data-tt-parent-id. I am getting all the class id's dynamically.

Other tablesorter files like - jquery.tablesorter.js have in my project.

Could you please help me to solve this issue please.

Thanks

@igorrebega
Copy link

Hello guys, have some ideas when this pull request will be merged (had the same issue and spend a full day to find the solution, but eventually Remy already fixed it)?

@Mottie
Copy link
Owner

Mottie commented Feb 13, 2018

Hi @igorrebega!

I plan to implement something similar to this if and when I ever get around to rewriting the plugin. As it stands now, it would require a big change to the internal cache that would break backward compatibility. So that's why I'm putting it off until the rewrite.

@mambax7
Copy link

mambax7 commented Jan 25, 2022

Any updates on this? It would be really cool to have it, as the demo looks very cool!

Or would any of the other solutions be easier to implement?
https://github.com/search?l=JavaScript&q=treetable.js&type=Repositories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants