Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add translation of Japanese #1438

Merged
merged 1 commit into from
Sep 28, 2023
Merged

add translation of Japanese #1438

merged 1 commit into from
Sep 28, 2023
+614 −0

Conversation

shsw228
Copy link
Contributor

@shsw228 shsw228 commented Sep 28, 2023

add translation of Japanese.
It's my first time contributing to OSS, so I'm worried about any problems....

thank you.

@shsw228
add translation of Japanese
4e015e9 
MonitorControl/UI/ja.lproj/InternetAccessPolicy.strings
MonitorControl/UI/ja.lproj/Localizable.strings
MonitorControl/UI/ja.lproj/Main.strings
waydabber
waydabber approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@waydabber waydabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shsw228! I can't judge how eloquent the translation is but from a technical aspect it is all right so I approve the merge. :)

@waydabber waydabber merged commit 8409761 into MonitorControl:main Sep 28, 2023
2 checks passed
@shsw228 shsw228 deleted the feature/add_Japanese_translation branch September 29, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waydabber waydabber waydabber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shsw228 @waydabber