Fix regex to remove last return statement #2460 #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knittl
force-pushed
the
bugfix/2460-build-regex
branch
3 times, most recently
from
ba40fdb
to
1ff59ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
=======================================
Coverage 95.18% 95.18%
=======================================
Files 5 5
Lines 166 166
=======================================
Hits 158 158
Misses 8 8
Continue to review full report at Codecov.
|
knittl
force-pushed
the
bugfix/2460-build-regex
branch
from
1ff59ab
to
b69ee43
Compare
Rewrite regex with character group used as negative lookahead. Instead, be explicit about what we want to match: the last return keyword in a string, followed by anything but newlines and ending with any number of trailing whitespace, semicolons, or closing parentheses or braces.
knittl
force-pushed
the
bugfix/2460-build-regex
branch
from
b69ee43
to
84b57ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite regex with character group used as negative lookahead. Instead,
be explicit about what we want to match: the last return keyword in a
string, followed by anything but newlines and ending with any number of
trailing whitespace, semicolons, or closing parentheses or braces.