Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference docs #46

Merged
merged 5 commits into from
May 28, 2024
Merged

Update reference docs #46

merged 5 commits into from
May 28, 2024

Conversation

tzujenchanmbd
Copy link

The initial 2 commits in this PR simply copy-pasted from reference doc in google/transit.

Potential pending items before merging:

  • Schedule
    • update changes in google/transit PR#464
    • links
  • Realtime
    • Trip Modification images
    • links

This commit simply copy-paste from google/transit
This commit simply copy-paste from google/transit
@Sergiodero
Copy link

Thanks for working on this! I've just reviewed PR#464 in google/transit, maybe we can merge that one and then update this PR. What do you think?

As for the trip modification images, currently, Fred set up a script to pull the images from google/transit to GTFS.org, but there has been some small problems and it's not working 100% yet, so we probably need to bring them manually into the assets folder and then update each link so that the images render properly.

Also a question: which links specifically are you referring to?

Thanks again!

@tzujenchanmbd
Copy link
Author

Thanks for the clarification!

PR#464merged, revision date updated - bcdd939
Added Trip Modification images - 0bc379c & 9e3ccd7

I was mentioning Trip Modification image or revision history links, other in-doc links should be okay. Could you review if the image can present properly? @Sergiodero

Copy link

@Sergiodero Sergiodero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tzujenchanmbd! I can confirm that the images are working, they are quite big when displayed in large window but that's something we need to fix/coordinate with Fred.

Screenshot 2024-05-27 at 4 29 58 PM

I'm approving the changes

@Sergiodero Sergiodero merged commit 40ce04c into main May 28, 2024
@Sergiodero Sergiodero deleted the update_reference_docs branch May 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants