Added users parameter in cross-validate #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blondered
requested changes
Mar 4, 2024
| @@ -48,6 +48,7 @@ def cross_validate( # pylint: disable=too-many-locals | |||
| models: tp.Dict[str, ModelBase], | |||
| k: int, | |||
| filter_viewed: bool, | |||
| users: tp.Optional[ExternalIds] = None, | |||
There was a problem hiding this comment.
Hi! Thank you for contribution!
Could you please add the following to your PR:
- Make
usersparameter as the last last one - Add profound testing in
tests/model_selection/test_cross_validate.py. Please ensure that math is correctly checked there. We believe that tests are really important - Add your change in CHANGELOG.md
There was a problem hiding this comment.
Thanks for the feedback, I'm on it.
There was a problem hiding this comment.
- I've moved the users parameter to the last
- looking into the test_cross_validate.py
- Moved users to the last - used dataset.user_id_map.convert_to_internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added users parameter in cross-validate.py to the request : #90
This will help to solve a common task to calculate metrics only on specific subset of usersType of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.