Put remainder of packed tests into last bundle when using estimated times #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ksuther, thanks for the PR. It would be great if you can add a test for this. |
ravimandala
requested changes
Feb 10, 2022
| @@ -146,6 +146,10 @@ @implementation BPPacker | |||
| if (splitExecTime + [testTimes[test] doubleValue] <= optimalBundleTime) { | |||
| splitExecTime += [testTimes[test] doubleValue]; | |||
| } else { | |||
| if ([bundles count] == [[config numSims] integerValue] - 1) { | |||
There was a problem hiding this comment.
Please add tests for this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using time estimates, the remainder tests get put into a new bundle when exceeding the optimal execution time. For example, if you set numSims to 5, you end up with 5 fully packed bundles and 1 one smaller leftover bundle.
This means you end up running 6 simulators even though numSims is 5. The extra time waiting for the 6th simulator to start takes a while and at least in my tests takes longer than simply appending the remainder to the final bundle.