Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ChannelManager.kt #637

Merged
merged 4 commits into from
Jun 1, 2024
Merged

Conversation

lukisk
Copy link
Contributor

@lukisk lukisk commented May 21, 2024

Closes #636

Description

The cancellation exception on upstream channel does not cause the closure of all other channels.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test Plan

How has this been tested? Please describe the tests that you added to verify your changes.

Checklist:

Before submitting your PR, please review and check all of the following:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective
  • New and existing unit tests pass locally with my changes

Additional Notes:

The cancellation exception from the upstream channel was caught in the StoreActor while handling messages. This caused the closure of the actor.

@digitalbuddha
Copy link
Contributor

Good catch! Do you mind adding a test to prove the functionality?

@lukisk
Copy link
Contributor Author

lukisk commented May 21, 2024

yes, i will do it

Signed-off-by: Luki <[email protected]>
@lukisk
Copy link
Contributor Author

lukisk commented May 31, 2024

@digitalbuddha please, can you check it?

Minor changes for readability, consistency, and scope management
Copy link
Collaborator

@matt-ramotar matt-ramotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukisk 👍🏽

@matt-ramotar matt-ramotar merged commit cc39941 into MobileNativeFoundation:main Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Calling 'fresh' under heavy load causes the upstream to close unexpectedly
3 participants