SPI pins are fixed #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Community folder for this pull request: |
|
Why is this? I think when I started with this, all pins were freely assignable. |
Nearly from the beginning on this device uses the HW SPI. Maybe you remember the slow refresh rate if using SW SPI. There too much data to do it this way. SInce then the readme stated to use fixed pins (the HW SPI ones), I think this makes no sense. Better to exclude them from the board.json and device.json file, it's also an example how to handle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This display uses the hardware SPI interface, so two pins are fixed and cannot be chosen within the configuration as before.
CLK, MOSI and MISO are deleted from the board.json files.
CLK and Data are deleted from the device.json as they don't need to be configured anymore.
Readme file is updated accordingly.