Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sql-server-linux-performance-best-practices.md #9761

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

bangjiehan
Copy link
Contributor

Add a note for open file limitation.

This setting do not apply to systemd services.
Most Linux dist now have hard limit of nofile at least 1048576.

There is no reason to set a lower soft limit and I don't know why original author choose a value of 32727 ($2^{15}-1-40$).

Add a note for open file limitation.

This setting do not apply to systemd services.
Most Linux dist now have hard limit of nofile at least 1048576.
Copy link
Contributor

@bangjiehan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit d27ef84:

✅ Validation status: passed

File Status Preview URL Details
docs/linux/sql-server-linux-performance-best-practices.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Apr 19, 2024

@tejasaks

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Apr 19, 2024
@tejasaks
Copy link
Contributor

Adding @amitkh-msft to review. Original entry was made for Red Hat Enterprise Linux 7 which had a much lower default limit and caused certain issues. probably doesn't apply to RHEL 9 or even 8 but needs to be verified.

Copy link
Contributor

Learn Build status updates of commit 5e6bcfa:

✅ Validation status: passed

File Status Preview URL Details
docs/linux/sql-server-linux-performance-best-practices.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 2263eb3:

✅ Validation status: passed

File Status Preview URL Details
docs/linux/sql-server-linux-performance-best-practices.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@rwestMSFT rwestMSFT merged commit 316dbd9 into MicrosoftDocs:live Jun 10, 2024
2 checks passed
Copy link
Contributor

PR 9761 has been merged from bangjiehan:patch-1 to MicrosoftDocs:live by rwestMSFT.

@bangjiehan, @tejasaks, @amitkh-msft, @rwestMSFT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants