Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api-management-api-import-restrictions.md #122244

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anjalidivitha
Copy link
Contributor

By default, APIM tries to convert all required query parameters into Url template parameters, and Url template parameters must be case insensitive unique.

By default, APIM tries to convert all required query parameters into Url template parameters, and Url template parameters must be case insensitive unique.
Copy link
Contributor

@anjalidivitha : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 037866a:

✅ Validation status: passed

File Status Preview URL Details
articles/api-management/api-management-api-import-restrictions.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented May 6, 2024

@dlepow

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label May 6, 2024
Copy link
Contributor

@dlepow dlepow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see suggested edit. Thanks!

@dlepow
Copy link
Contributor

dlepow commented May 11, 2024

@anjalidivitha - Thanks for the PR. The addition seems to duplicate the previous line in part which mentions "unique". Could you add the "case-insensitive" part to the previous line instead, e.g. "

  • OpenAPI doesn't support this discrimination, so we require parameter names to be unique within the entire URL template. Names are case-insenstive.
  • " Thanks!

    @anjalidivitha
    Copy link
    Contributor Author

    @dlepow, thanks for the feedback. I made changes as suggested. Thanks! :)

    Copy link
    Contributor

    Learn Build status updates of commit 390c5ab:

    ✅ Validation status: passed

    File Status Preview URL Details
    articles/api-management/api-management-api-import-restrictions.md ✅Succeeded

    For more details, please refer to the build report.

    For any questions, please:

    @dlepow
    Copy link
    Contributor

    dlepow commented May 15, 2024

    Thank you @anjalidivitha! LGTM.
    #sign-off

    @Jak-MS
    Copy link
    Contributor

    Jak-MS commented May 15, 2024

    Due to the upcoming Build conference, all merging and publishing is on hold until the morning of 5/21.

    This PR is ready for merge on 5/21.

    #label: "event-triaged-to-10AM"
    #label: "missed-content-complete"

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    4 participants