Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-rbac.md #122203

Merged
merged 2 commits into from May 7, 2024
Merged

Update azure-rbac.md #122203

merged 2 commits into from May 7, 2024

Conversation

Elektronenvolt
Copy link
Contributor

Add an Azure CLI >= v2.3.7 and <v2.3.7 section for the SPN reset as it's in line 44 and 139 for setup. Please check if rendering is ok, don't see it in the preview.

Add a Azure CLI >= v2.3.7 and <v2.3.7 section for the SPN reset as it's in line  44 and 139 for setup. Please check if rendering is ok, don't see it in the preview.
Copy link
Contributor

@Elektronenvolt : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 1dde4f8:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-arc/kubernetes/azure-rbac.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented May 3, 2024

@JnHs

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label May 3, 2024
@JnHs
Copy link
Contributor

JnHs commented May 6, 2024

Thanks @Elektronenvolt!
#sign-off

@JnHs
Copy link
Contributor

JnHs commented May 6, 2024

@Court72 I just realized this is missing the
---
to mark the end of the tabbed sections. Could you please add that before merging? It should be right before the Next steps heading.

Copy link
Contributor

Learn Build status updates of commit daa09aa:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-arc/kubernetes/azure-rbac.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72 Court72 merged commit e7362e3 into MicrosoftDocs:main May 7, 2024
2 checks passed
@Elektronenvolt
Copy link
Contributor Author

@Court72 I just realized this is missing the --- to mark the end of the tabbed sections. Could you please add that before merging? It should be right before the Next steps heading.

Sorry for that, I didn't see this in the preview of the document.

Elektronenvolt added a commit to Elektronenvolt/azure-docs that referenced this pull request May 13, 2024
Follow up to PR MicrosoftDocs#122203. End of the tabbed sections should be already before updating the secret on the cluster.
@Elektronenvolt Elektronenvolt deleted the patch-1 branch May 13, 2024 22:00
Elektronenvolt added a commit to Elektronenvolt/azure-docs that referenced this pull request May 13, 2024
Follow up to PR MicrosoftDocs#122203. End of the tabbed sections should be already before updating the secret on the cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants