made sops-install-secrets working when crossSystem is set #469
Conversation
modules/home-manager/sops.nix
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| let | |||
| cfg = config.sops; | |||
| sops-install-secrets = (pkgs.callPackage ../.. {}).sops-install-secrets; | |||
| sops-install-secrets = (pkgs.buildPackages.callPackage ../.. {}).sops-install-secrets; | |||
There was a problem hiding this comment.
Are you sure this correct?
sops-install-secrets needs to run on the host system i.e if you do a x86_64 -> aarch64 build than this would yield an x86_64 binary that cannot run on aarch64 at activation time.
There was a problem hiding this comment.
When do you encounter a case where this is needed at build time?
There was a problem hiding this comment.
Ah right, I'm not sure this is correct.
I encounter this not a build time but at activation time as I deploy a x86_64 node an aarch64 home-manager profile that is cross compiled. In this case, the activation scripts need to be x86_64 instead of aarch64.
See nix-community/home-manager#4907, where I've made a similar PR for home-manager.
This will break more "standard" workflow where the activation is done in the node itself.
May I propose an update with an option like activationPackageSet defaulting to pkgs?
There was a problem hiding this comment.
You are deploying an aarch64 profile on a x86_64 node? How do you use aarch64 binaries on x86_64? I don't understand the use case. As the patch is just now it would break cross setups i.e. I have a riscv64 machine that gets build by a x86 machine.
There was a problem hiding this comment.
My $HOME is on a NFS mount point that is shared between several nodes (x86_64 and aarch64).
As the aarch64 nodes are not much powerfull (or used by other users), my aarch64 profile is build on a x86_64 node and also deployed from it.
NB: On that cluster, binfmt_misc is not configured to run aarch64 binaries on x86_64.
There was a problem hiding this comment.
Ok. But don't you run the activation phase (nixos-rebuild switch) on the aarch64 machine natively?
There was a problem hiding this comment.
In fact not and that why I made this patch. I'm building and deploying from the build node.
I've updated this patch and its related patch on home-manager at nix-community/home-manager#4907
There was a problem hiding this comment.
Ok. I can merge this, when home-manager patch is in.
dguibert
force-pushed
the
dg/use-with-cross-system
branch
from
219e5f3
to
f7e369e
Compare
In NixOS setting
CrossSystemallow to compile for a system that can be different of the host system but the tools that need to be run on the build host must come frompkgs.buildPackages.