Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array sorting #32

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

langhard
Copy link

It's not drag and drop (Issue #6), but a possibility to sort the arrays.

@MhdSyrwan
Copy link
Owner

MhdSyrwan commented Mar 30, 2018

Great, I will check this in the evening.
BTW, I think calling this feature sorting would be misleading. It should be called re-ordering, ordering .. etc.

Do you have any name suggestions ?

@langhard
Copy link
Author

Cool, thx!
I like „sorting“ but (re-)ordering is also ok.

@langhard
Copy link
Author

langhard commented Apr 3, 2018

Could you already have a look at the PR?

@MhdSyrwan
Copy link
Owner

MhdSyrwan commented Apr 3, 2018

I had a closer look at the code, but unfortunately haven't had the chance to run it.

Let's create a task list:

  • Rename feature name related variables, prop names and documentation.
  • Add some test cases to the test suite regarding this feature.
  • Make sure that the method you used Array.prototype.move exists in any current/future standard.

@langhard
Copy link
Author

Updated task list:

  • Rename feature name related variables, prop names and documentation.
  • Add some test cases to the test suite regarding this feature.
  • Make sure that the method you used Array.prototype.move exists in any current/future standard.

Question:
What do you mean with "Make sure that the method you used Array.prototype.move exists in any current/future standard." Can you help me with that?

@MhdSyrwan
Copy link
Owner

MhdSyrwan commented Apr 11, 2018

@langhard I've researched more about the move method. I was mistakenly thinking that it's an obsolete method of the JavaScript array prototype. And forgot about the fact that items is a FieldArray and not a normal JS array.

Currently our new todo list is:

  • Rename feature name related variables, prop names and documentation.
  • Add some test cases to the test suite regarding this feature.

Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants