feat(snaps-utils): Allow overriding allowed protocols in validateLink #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
configurable-protocols
branch
from
fb6eb15
to
bf7ef9c
Compare
legobeat
force-pushed
the
configurable-protocols
branch
from
f2f9505
to
eab77b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2411 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 435 435
Lines 8942 8942
Branches 1374 1376 +2
=======================================
Hits 8430 8430
Misses 512 512 ☔ View full report in Codecov by Sentry. |
legobeat
force-pushed
the
configurable-protocols
branch
from
7096061
to
0d113d7
Compare
legobeat
force-pushed
the
configurable-protocols
branch
from
0d113d7
to
d066a8c
Compare
|
@legobeat What is the use-case here? 🤔 |
| @@ -272,6 +272,7 @@ export class SnapInterfaceController extends BaseController< | |||
| ); | |||
|
|
|||
| await this.#triggerPhishingListUpdate(); | |||
| // TODO: Expose configuration for allowedProtocols in validateJsxLinks | |||
There was a problem hiding this comment.
This change isn't very impactful until this is done, since all UI is converted to JSX as of recently.
| isOnPhishingList, | ||
| maybeUpdatePhishingList, | ||
| }: NotifyMethodHooks, | ||
| allowedProtocols?: string[], |
There was a problem hiding this comment.
Does the PermissionController support this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By popular request, allow specifying custom protocols for link validation.