Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.4.3 #8

Merged
merged 1 commit into from
May 30, 2024
Merged

Release v2.4.3 #8

merged 1 commit into from
May 30, 2024

Conversation

legobeat
Copy link

@legobeat legobeat commented May 4, 2024

This is the release candidate of @metamask/react-native-actionsheet v2.4.3.


Changes since v2.4.2:

@legobeat legobeat requested review from rickycodes and a team May 4, 2024 01:08
@legobeat legobeat marked this pull request as ready for review May 4, 2024 01:08
@legobeat legobeat changed the title @metamask/react-native-actionsheet v2.4.3 Release v2.4.3 May 4, 2024
@legobeat legobeat requested a review from Cal-L May 4, 2024 01:09
Copy link

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat merged commit cfef195 into main May 30, 2024
4 checks passed
@legobeat
Copy link
Author

legobeat commented May 31, 2024

npm notice package: @metamask/[email protected]
npm notice === Tarball Contents ===
npm notice 1.1kB LICENSE
npm notice 3.9kB README.md
npm notice 5.6kB lib/ActionSheetCustom.js
npm notice 836B  lib/ActionSheetIOS.js
npm notice 346B  lib/index.js
npm notice 1.0kB lib/options.js
npm notice 1.7kB lib/styles.js
npm notice 361B  lib/utils.js
npm notice 1.6kB package.json
npm notice === Tarball Details ===
npm notice name:          @metamask/react-native-actionsheet
npm notice version:       2.4.3
npm notice filename:      metamask-react-native-actionsheet-2.4.3.tgz
npm notice package size:  5.4 kB
npm notice unpacked size: 16.4 kB
npm notice shasum:        6bc589ac472f2c74cf1293940a00923217082e4f
npm notice integrity:     sha512-mHDWcFPU052F+[...]0rHEOzVXvVlyQ==
npm notice total files:   9

Note: When publishing, I noted that linting fails and the tests won't start at all (which we didn't see because of lack of CI x manual test process). Doesn't seem to make a difference to previous version so published as-is.

$ yarn test
yarn run v1.22.22
$ jest --no-cache
● Validation Error:

  Preset react-native not found.

  Configuration Documentation:
  https://facebook.github.io/jest/docs/configuration.html

error Command failed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants