Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update base nickname #9682

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: update base nickname #9682

merged 1 commit into from
May 28, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented May 18, 2024

Description

PR to update base nickname from Base Mainnet to Base.

Related issues

Fixes:
Relates to: #9631

Manual testing steps

  1. Go to Settings => Networks => Add Network
  2. You should be able to see the Name Base and add the network.

Screenshots/Recordings

Before

Screen.Recording.2024-05-18.at.21.56.58.mov

After

Screen.Recording.2024-05-18.at.21.49.59.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner May 18, 2024 19:57
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels May 18, 2024
Copy link

sonarcloud bot commented May 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 18, 2024
Copy link
Contributor

github-actions bot commented May 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cd5d810
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a324717c-8053-4350-8c2e-c07f99e099c1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L

This comment was marked as outdated.

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a migration if Base was previously added as a network?

@sahar-fehri sahar-fehri mentioned this pull request May 23, 2024
7 tasks
@sahar-fehri
Copy link
Contributor Author

Do we need a migration if Base was previously added as a network?

Hey @Cal-L ! I had a very similiar PR for Sepolia. Similarly, i dnt think a migration is needed since the nickname does not appear to be in the config.

@sahar-fehri sahar-fehri merged commit c547165 into main May 28, 2024
41 of 42 checks passed
@sahar-fehri sahar-fehri deleted the fix/update-base-nickname branch May 28, 2024 14:49
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.24.0 Issue or pull request that will be included in release 7.24.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants