Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: temp pr #9681

Closed
wants to merge 24 commits into from
Closed

refactor: temp pr #9681

wants to merge 24 commits into from

Conversation

EtherWizard33
Copy link
Contributor

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

EtherWizard33 and others added 24 commits May 17, 2024 16:00
@EtherWizard33
refactor: create the new selector and use it in tab thumbnail component
45cd400
@EtherWizard33
fix: import from named to default
f74ae27
@EtherWizard33
refactor: get the network name from the selector rather than the util
ffe93e5
@EtherWizard33
refactor: use selector instead of utils to get the networkName of Acc…
b265458 
…ountRightButton
@EtherWizard33
style: lint
7e4c95d
@EtherWizard33
refactor: use selector instead of utils to get the networkName of Man…
9a6a45b 
…ageNetworks component
@EtherWizard33
refactor: use selector instead of utils to get the networkName of Net…
37f2086 
…workInfo component
@EtherWizard33
refactor: use selector instead of utils to get the networkName of
62c852b 
SearchTokenAutocomplete component
@EtherWizard33
refactor: use selector instead of utils to get the networkName of Tok…
b1bd5b0 
…ens component
@EtherWizard33
refactor: use selector instead of utils to get the networkName of Acc…
bbbe6b3 
…ountPermissionsConnected component
@EtherWizard33
refactor: use selector instead of utils to get the networkName of Wal…
1bfdafc 
…let component
@EtherWizard33
refactor: use selector instead of utils to get the networkName of Add…
92ca67e 
…Asset and ApproveTransactionHeader components
@EtherWizard33
refactor: network image util into a selector (#9644)
84d8082 
refactor: use new selector instead of utils to get the networkImageSource
@EtherWizard33
test: revert change since this component should keep using the util
b023f79
@EtherWizard33
test: update the unit test to mock the new selector, this was flagged…
9b29cc3 
… to the snapshot that was unnexpectedly changed
@EtherWizard33
est: update the ManageNetwork component test to mock the new selector
c35900e
@EtherWizard33
test: update the NetworkModal component test to mock the new selector
5db5314
@EtherWizard33
test: this component gets names of custom networks, it should keep us…
5efa852 
…ing the util, reverting the change to use selector in this component
@EtherWizard33
style: lint
2117f9f
@EtherWizard33
test: revert to original snapshot
6d3fc93
@EtherWizard33
refactor: rename variable
9e09fd7
@EtherWizard33
refactor: rename variable
f5d323b
@EtherWizard33
feat: revert back the previous change which was making the filteredNe…
c0ec30b 
…tworks to use the selected one instead
@EtherWizard33
test: this component gets names for specific chain ids, it should kee…
9ec2937 
…p using the util, reverting the change
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 changed the title temp pr refactor: temp pr May 17, 2024
@EtherWizard33 EtherWizard33 marked this pull request as ready for review May 17, 2024 20:19
@EtherWizard33 EtherWizard33 requested review from a team as code owners May 17, 2024 20:19
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner May 17, 2024 20:19
@legobeat legobeat marked this pull request as draft May 20, 2024 05:12
@legobeat legobeat added the DO-NOT-MERGE Pull requests that should not be merged label May 20, 2024
@EtherWizard33 EtherWizard33 deleted the temp-branch branch May 30, 2024 17:44
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
DO-NOT-MERGE Pull requests that should not be merged team-wallet-ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EtherWizard33 @legobeat