Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Delete MetaMetrics Data copy to 30 days #9674

Merged
merged 3 commits into from
May 31, 2024

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented May 17, 2024

Description

  • Update copy from 60 to 30 days
  • Update initial text to remove part two and add a link on Metametrics (requires to split text in 3 parts) See change request comment
  • The text change required to reorganise keys.
  • New more explicit names used to clarify code and ease translation

Related issues

fixes MetaMask/mobile-planning#1797

Manual testing steps

  1. Go to settings / Security & Privacy.
  2. scroll to "delete metametrics data" section.
  3. check description matches @hesterbruikman comment:

This will delete historical MetaMetrics data associated with your use on this device. Your wallet and accounts will remain exactly as they are now after this data has been deleted. This process may take up to 30 days. View our Privacy Policy.

  1. Check "MetaMetrics" and "Privacy Policy" links.
  2. Touch "Delete MetaMetrics Data" button.
  3. Touch "CLEAR" in the confirmation popup.
  4. Check the confirmation message says "30 days".
  5. Check "Privacy Policy" link.

Screenshots/Recordings

Screen.Recording.2024-05-24.at.17.34.13.mov

Before

After

image

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@hesterbruikman
Copy link
Contributor

@NicolasMassart could you please update to

This will delete historical MetaMetrics data associated with your use on this device. Your wallet and accounts will remain exactly as they are now after this data has been deleted. This process may take up to 30 days. View our Privacy Policy.

This also removes the reference to anonymous.

cc @gauthierpetetin

@gauthierpetetin
Copy link
Contributor

Hi @NiranjanaBinoy , I'm cc ing you to make sure we replicate the latest copy updates (cf. Hester's message above) on Extension side as well.

@NicolasMassart NicolasMassart marked this pull request as draft May 21, 2024 15:28
@NicolasMassart NicolasMassart force-pushed the 1797_update_data_deletion_copy branch from 53e5e0c to 8ee5376 Compare May 24, 2024 12:55
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
delete all languages keys to be replaced by new one
@NicolasMassart NicolasMassart requested a review from desi May 24, 2024 15:54
@NicolasMassart NicolasMassart added the DO-NOT-MERGE Pull requests that should not be merged label May 24, 2024
@NicolasMassart NicolasMassart marked this pull request as ready for review May 24, 2024 17:31
@desi desi added the ready-for-translation This is used in a github action to trigger a branch as ready for translation team to pick up label May 24, 2024
@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 30, 2024
@github-actions github-actions bot unlocked this conversation May 30, 2024
Copy link
Contributor

github-actions bot commented May 30, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0bdfdab
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/612dc36d-0168-4abe-856c-e44858476405

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented May 31, 2024

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed DO-NOT-MERGE Pull requests that should not be merged ready-for-translation This is used in a github action to trigger a branch as ready for translation team to pick up labels May 31, 2024
@sethkfman sethkfman merged commit cd796ce into main May 31, 2024
33 of 35 checks passed
@sethkfman sethkfman deleted the 1797_update_data_deletion_copy branch May 31, 2024 20:41
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
@metamaskbot metamaskbot added the release-7.25.0 Issue or pull request that will be included in release 7.25.0 label May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
marketing-consent release-7.25.0 Issue or pull request that will be included in release 7.25.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants