Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metametrics toast #9666

Closed
wants to merge 1 commit into from
Closed

feat: add metametrics toast #9666

wants to merge 1 commit into from

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented May 17, 2024

Description

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2437

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sentry-io bot commented May 17, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/components/Nav/App/index.js

Function Unhandled Issue
App Error: TaskQueue: Error with task : The 'navigation' object hasn't been initialized yet. This might happ... useEf...
Event Count: 983 Affected Users: 1.1k

Did you find this useful? React with a 👍 or 👎

Copy link

sonarcloud bot commented May 17, 2024

@jonybur jonybur closed this May 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant