feat: added design tokens eslint rules to mobile #9653
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
georgewrmarshall
added
the
team-design-system
… hex color values
Comment on lines
+42
to
+47
| { | ||
| files: ['**/*.test.{js,ts,tsx}', '**/*.stories.{js,ts,tsx}'], | ||
| rules: { | ||
| '@metamask/design-tokens/color-no-hex': 'off', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Ignores tests and stories
| @@ -11,7 +11,7 @@ module.exports = { | |||
| 'plugin:import/warnings', | |||
| 'plugin:react/recommended', | |||
| ], | |||
|
|
|||
| plugins: ['@metamask/design-tokens'], | |||
There was a problem hiding this comment.
Was missing this step @brianacnguyen
| @@ -1,3 +1,5 @@ | |||
| // Intentionally using non-design system colors here | |||
| /* eslint-disable @metamask/design-tokens/color-no-hex*/ | |||
There was a problem hiding this comment.
Ignoring as it's an image asset component
| @@ -1,3 +1,5 @@ | |||
| // Intentionally using non-design system colors here | |||
| /* eslint-disable @metamask/design-tokens/color-no-hex*/ | |||
There was a problem hiding this comment.
Ignoring as it's an image asset component
georgewrmarshall
force-pushed
the
color-no-hex
branch
from
95e2429
to
c4aa7f4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
linting.mp4
Pre-merge author checklist
Pre-merge reviewer checklist