feat: Upgrade signature Controller to v14

[MarioAslau]

Description

Update Signature Controller to v^14

Changelog: https://github.com/MetaMask/core/blob/%40metamask/signature-controller%4016.0.0/packages/signature-controller/CHANGELOG.md

These two peer dependencies:

• BREAKING: Bump dependency and peer dependency on @metamask/keyring-controller to ^14.0.0 (Release 124.0.0 core#4039)
• BREAKING: Bump dependency and peer dependency on @metamask/approval-controller to ^6.0.0 (Release 124.0.0 core#4039)

These two controllers are being used inside Signature Controller to import types.
These types have not been changed during the latest upgrades to these controllers, thus not being a breaking changes for Signature Controller V14.

Related issues

• feat: Upgrade Signature Controller to V14 - closed #9649

Manual testing steps

1. Turn on MetaMask and log into wallet
2. Go to Settings > Advanced > Turn on Eth_sign requests
3. Go to mobile browser and access https://metamask.github.io/test-dapp/
4. Use MetaMask wallet and Connect Wallet
5. Scroll down and test signing in: Eth Sign, Perosnal Sign, Sign Typed Data, Sign Typed Data V3, Sign Typed Data V4, Sign Permit, Sign in with Ethereum
6. Verify each of the singings where the button is present

Screenshots/Recordings

Before

After

Recording.11.mp4

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	Transitive: filesystem	+26	3.79 MB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 13e80c2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e32ea8a8-6cea-4fa6-a63d-bff457fabf6d

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4455e43
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e15a50dd-7b88-4b51-8e8f-2578617e9eb2

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[tommasini]

LGTM!
Awesome job!
If you can just add the manual steps and a recording of the behaviour of signing