Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transaction simulations preference #9648

Merged
merged 22 commits into from
Jun 6, 2024
Merged

feat: add transaction simulations preference #9648

merged 22 commits into from
Jun 6, 2024

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented May 16, 2024 •
edited

Description

This PR goal is to add upcoming transaction simulations toggle to security preferences.

Note: Toggle currently hidden behind a feature flag env which we aim to remove this week and enable.
Patched part of the preferences controller already applied to main here MetaMask/core#4283

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1720

Manual testing steps

  1. Security settings, toggle off "Estimated balance changes"
  2. Close app
  3. Open app and see if it still toggled off (also validate opposite to make sure PreferencesController updates accordingly)

Screenshots/Recordings

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-16.at.12.44.55.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead team-confirmations Push issues to confirmations team and removed team-confirmations-system DEPRECATED: please use "team-confirmations" label instead labels May 16, 2024
@OGPoyraz OGPoyraz marked this pull request as ready for review May 27, 2024 12:56
@OGPoyraz OGPoyraz requested review from a team as code owners May 27, 2024 12:56
digiwand
digiwand previously approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

one question to learn a bit more

patches/@metamask+preferences-controller+8.0.0.patch Outdated Show resolved Hide resolved
@OGPoyraz OGPoyraz force-pushed the 1720-add-privacy-toggle-to-disable-simulations branch from 27a1a7d to 944ead6 Compare May 30, 2024 07:47
@OGPoyraz OGPoyraz changed the title Add transaction simulations preference feat: add transaction simulations preference May 30, 2024
matthewwalsh0
matthewwalsh0 previously approved these changes Jun 3, 2024
View reviewed changes
@OGPoyraz OGPoyraz mentioned this pull request Jun 4, 2024
Open
7 tasks
vinistevam
vinistevam previously approved these changes Jun 4, 2024
View reviewed changes
digiwand
digiwand previously approved these changes Jun 4, 2024
View reviewed changes
@OGPoyraz OGPoyraz dismissed stale reviews from digiwand and vinistevam via c6e1559 June 4, 2024 12:16
digiwand
digiwand reviewed Jun 4, 2024
View reviewed changes
app/constants/urls.ts Outdated Show resolved Hide resolved
tommasini
tommasini previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please keep an eye when the release is cut, if the translations are there!

vinistevam
vinistevam previously approved these changes Jun 5, 2024
View reviewed changes
@OGPoyraz OGPoyraz dismissed stale reviews from vinistevam and tommasini via 869439c June 6, 2024 02:07
@OGPoyraz OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 869439c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc4db85e-64ba-4e42-9844-82b7ea9fa3d3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 6, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
73.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 771eb8e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/83dddc38-2d5e-495e-a725-cd3ece307719

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@OGPoyraz OGPoyraz merged commit e8816b8 into main Jun 6, 2024
35 checks passed
@OGPoyraz OGPoyraz deleted the 1720-add-privacy-toggle-to-disable-simulations branch June 6, 2024 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
@metamaskbot metamaskbot added the release-7.25.0 Issue or pull request that will be included in release 7.25.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpuri jpuri jpuri left review comments

@digiwand digiwand digiwand left review comments

@tommasini tommasini tommasini approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 left review comments

@vinistevam vinistevam vinistevam left review comments

Assignees
No one assigned
Labels
release-7.25.0 Issue or pull request that will be included in release 7.25.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@OGPoyraz @jpuri @matthewwalsh0 @digiwand @vinistevam @tommasini @metamaskbot