-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: the network name and image utils into selectors #9638
Conversation
…ageNetworks component
…workInfo component
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
SearchTokenAutocomplete component
…ountPermissionsConnected component
…Asset and ApproveTransactionHeader components
refactor: use new selector instead of utils to get the networkImageSource
app/components/Views/OnboardingSuccess/DefaultSettings/__snapshots__/index.test.js.snap
Outdated
Show resolved
Hide resolved
app/components/Views/NetworkSelector/__snapshots__/NetworkSelector.test.tsx.snap
Outdated
Show resolved
Hide resolved
… to the snapshot that was unnexpectedly changed
app/components/UI/Ramp/Views/NetworkSwitcher/__snapshots__/NetworkSwitcher.test.tsx.snap
Outdated
Show resolved
Hide resolved
app/components/Views/OnboardingSuccess/DefaultSettings/index.test.js
Outdated
Show resolved
Hide resolved
app/components/Views/OnboardingSuccess/DefaultSettings/index.test.js
Outdated
Show resolved
Hide resolved
app/components/Views/Settings/SecuritySettings/SecuritySettings.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After addressing the conversations and the unit test failure.
Could you record a video of the app-impacted screens?
…tworks to use the selected one instead
…p using the util, reverting the change
This reverts commit 88328dd.
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. What is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we removing the close option in toast?
Hi Brian, this PR got merged with too much content which included stuff about the close option which is not part of this PR. |
Description
We are replacing calls to the get network name and get network image from utils to use a selector instead.
This way all places referring to it will do so in the same way and all with the same memoization provided by reselect.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist