Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add blockaid validation support for OPBNB network. #24361

Merged
merged 2 commits into from May 8, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented May 3, 2024

Description

Add blockaid validation support for OPBNB network.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2392

Manual testing steps

  1. Switch to opBNB network
  2. Submit transaction
  3. Ensure blockaid validation is done

Screenshots/Recordings

Screenshot 2024-05-03 at 5 23 10 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented May 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 3, 2024
@jpuri jpuri marked this pull request as ready for review May 6, 2024 11:10
@jpuri jpuri requested a review from a team as a code owner May 6, 2024 11:10
@sleepytanya
Copy link
Contributor

sleepytanya commented May 6, 2024

Looks great from QA side!
Dev build b19af64

Screenshot 2024-05-06 at 17 04 28

@metamaskbot
Copy link
Collaborator

Builds ready [b19af64]
Page Load Metrics (723 ± 546 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint56142892612
domContentLoaded85518147
load4528287231136546
domInteractive85518147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 87 Bytes (0.00%)

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (f0ac9c0) to head (6ccc595).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24361   +/-   ##
========================================
  Coverage    67.34%   67.34%           
========================================
  Files         1282     1282           
  Lines        50066    50067    +1     
  Branches     12986    12986           
========================================
+ Hits         33716    33717    +1     
  Misses       16350    16350           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit 4dd9d52 into develop May 8, 2024
71 of 72 checks passed
@jpuri jpuri deleted the opbnb_blockaid_support branch May 8, 2024 07:47
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 8, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [6ccc595]
Page Load Metrics (596 ± 510 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5612380136
domContentLoaded8221442
load4529645961063510
domInteractive8221442
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 13 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 87 Bytes (0.00%)

@metamaskbot metamaskbot added release-11.17.0 Issue or pull request that will be included in release 11.17.0 and removed release-11.18.0 Issue or pull request that will be included in release 11.18.0 labels May 23, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed release-11.17.0 Issue or pull request that will be included in release 11.17.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants