chore: bump assets controllers to latest #24360

sahar-fehri · 2024-05-03T09:27:42Z

Description

Bumps assets-controllers to latest.

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-05-03T09:27:57Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-05-03T09:28:52Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	Transitive: environment	`+15`	5.9 MB	metamaskbot
npm/@metamask/[email protected]	None	`+5`	1.25 MB	metamaskbot
npm/@types/[email protected]	None	`0`	3.2 kB	types
npm/[email protected]	None	`0`	409 kB	connor.peet
npm/[email protected]	None	`0`	81.8 kB	acubed

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

sahar-fehri · 2024-05-03T09:50:53Z

@metamaskbot update-policies

metamaskbot · 2024-05-03T09:59:15Z

Policies updated

codecov · 2024-05-03T13:19:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.38%. Comparing base (4519cac) to head (d13aff2).

❗ Current head d13aff2 differs from pull request most recent head e87e242. Consider uploading reports for the commit e87e242 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24360      +/-   ##
===========================================
+ Coverage    67.36%   67.38%   +0.02%     
===========================================
  Files         1285     1285              
  Lines        50088    50052      -36     
  Branches     12996    12992       -4     
===========================================
- Hits         33738    33726      -12     
+ Misses       16350    16326      -24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-05-03T13:34:03Z

Builds ready [a8e77c6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (953 ± 653 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	150	94	22	10
		domContentLoaded	9	38	15	7	3
		load	50	3488	953	1359	653
		domInteractive	9	38	15	7	3

Bundle size diffs [🚀 Bundle size reduced!]

background: -30 Bytes (-0.00%)
ui: -2 Bytes (-0.00%)
common: -41.45 KiB (-0.70%)

legobeat · 2024-05-04T01:38:09Z

@metamask/assets-controllers has a peerDependency on @metamask/account-controllers.

Before this change, the direct dependency version of @metamask/account-controllers satisfies the peerDependency requirement. This change will break it. Also upgrading @metamask/account-controllers from ^11.0.0 to ^14.0.0 would make them align again.

I haven't looked closer than this, but I would think that there is something behind the peerDependency bumps?

Is it actually safe, or should @metamask/account-controllers also be upgraded alongside?

metamaskbot · 2024-05-06T22:52:05Z

Builds ready [99c3db1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1256 ± 636 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	224	95	38	18
		domContentLoaded	9	53	16	10	5
		load	56	2935	1256	1325	636
		domInteractive	9	53	16	10	5

Bundle size diffs [🚀 Bundle size reduced!]

background: -30 Bytes (-0.00%)
ui: -2 Bytes (-0.00%)
common: -41.45 KiB (-0.70%)

sahar-fehri · 2024-05-06T22:53:50Z

@metamask/assets-controllers has a peerDependency on @metamask/account-controllers.

Before this change, the direct dependency version of @metamask/account-controllers satisfies the peerDependency requirement. This change will break it. Also upgrading @metamask/account-controllers from ^11.0.0 to ^14.0.0 would make them align again.

I haven't looked closer than this, but I would think that there is something behind the peerDependency bumps?

Is it actually safe, or should @metamask/account-controllers also be upgraded alongside?

Hey @legobeat! that's a good point! I think i expected to see build errors or errors in console extension/background if a peer dependency needed an upgrade, i have tested this PR locally and i do not see any errors.
I see the changelog in core marked accounts-controller v14.0.0 as breaking but maybe it does not necessarily need an update?

metamaskbot · 2024-05-07T14:47:11Z

Builds ready [a23a64a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1302 ± 660 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	225	105	39	19
		domContentLoaded	9	94	18	18	9
		load	50	3250	1302	1375	660
		domInteractive	9	94	18	18	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -30 Bytes (-0.00%)
ui: -2 Bytes (-0.00%)
common: -41.45 KiB (-0.67%)

metamaskbot · 2024-05-07T15:50:19Z

Builds ready [a23a64a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1302 ± 660 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	225	105	39	19
		domContentLoaded	9	94	18	18	9
		load	50	3250	1302	1375	660
		domInteractive	9	94	18	18	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -30 Bytes (-0.00%)
ui: -2 Bytes (-0.00%)
common: -41.45 KiB (-0.67%)

sahar-fehri · 2024-05-07T18:59:46Z

@metamaskbot update-policies

socket-security · 2024-05-07T19:01:56Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

metamaskbot · 2024-05-07T19:07:40Z

Policies updated

mcmire · 2024-05-07T19:50:11Z

I just checked through the changes in the peer dependencies that assets-controllers has, and most of them are type-related, so they don't have an impact here. It seems that we can address those upgrades in a separate PR.

metamaskbot · 2024-05-07T21:37:00Z

Builds ready [d13aff2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1247 ± 703 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	181	94	26	13
		domContentLoaded	9	22	12	3	1
		load	58	3754	1247	1463	703
		domInteractive	9	22	12	3	1

Bundle size diffs [🚀 Bundle size reduced!]

background: -30 Bytes (-0.00%)
ui: -2 Bytes (-0.00%)
common: -41.45 KiB (-0.67%)

metamaskbot · 2024-05-07T22:25:15Z

Builds ready [e87e242]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (687 ± 522 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	139	80	16	8
		domContentLoaded	9	18	11	2	1
		load	49	2875	687	1088	522
		domInteractive	9	18	11	2	1

Bundle size diffs [🚀 Bundle size reduced!]

background: -30 Bytes (-0.00%)
ui: -2 Bytes (-0.00%)
common: -41.45 KiB (-0.67%)

mcmire

Looks good!

metamaskbot · 2024-05-23T23:07:53Z

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.

sahar-fehri requested a review from a team as a code owner May 3, 2024 09:27

sahar-fehri self-assigned this May 3, 2024

sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets labels May 3, 2024

sahar-fehri requested review from a team as code owners May 3, 2024 09:59

bergeron previously approved these changes May 3, 2024

View reviewed changes

salimtb previously approved these changes May 6, 2024

View reviewed changes

sahar-fehri dismissed stale reviews from salimtb and bergeron via 99c3db1 May 6, 2024 21:41

sahar-fehri force-pushed the chore/bump-assets-controller branch from 99c3db1 to a23a64a Compare May 7, 2024 12:27

sahar-fehri and others added 7 commits May 7, 2024 20:51

chore: bump assets controllers to latest

cdce4b4

fix: update snapshot

4a201e8

fix: yarn dedupe

06aa524

Update LavaMoat policies

db92176

fix: fix e2e

6fb11d4

fix: fix lint

2bdcc7c

fix: rebase

f978a0a

fix: fix yarn

c2ebbfb

sahar-fehri force-pushed the chore/bump-assets-controller branch from a23a64a to c2ebbfb Compare May 7, 2024 18:53

Update LavaMoat policies

d13aff2

bergeron approved these changes May 7, 2024

View reviewed changes

darkwing approved these changes May 7, 2024

View reviewed changes

Merge branch 'develop' into chore/bump-assets-controller

e87e242

salimtb approved these changes May 7, 2024

View reviewed changes

mcmire approved these changes May 7, 2024

View reviewed changes

sahar-fehri merged commit 39e7512 into develop May 7, 2024
72 checks passed

sahar-fehri deleted the chore/bump-assets-controller branch May 7, 2024 23:24

github-actions bot locked and limited conversation to collaborators May 7, 2024

metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 7, 2024

metamaskbot added release-11.17.0 Issue or pull request that will be included in release 11.17.0 and removed release-11.18.0 Issue or pull request that will be included in release 11.18.0 labels May 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump assets controllers to latest #24360

chore: bump assets controllers to latest #24360

sahar-fehri commented May 3, 2024 •

edited by github-actions bot

github-actions bot commented May 3, 2024

socket-security bot commented May 3, 2024 •

edited

sahar-fehri commented May 3, 2024

metamaskbot commented May 3, 2024

codecov bot commented May 3, 2024 •

edited

metamaskbot commented May 3, 2024

legobeat commented May 4, 2024 •

edited

metamaskbot commented May 6, 2024

sahar-fehri commented May 6, 2024 •

edited

metamaskbot commented May 7, 2024

metamaskbot commented May 7, 2024

sahar-fehri commented May 7, 2024

socket-security bot commented May 7, 2024 •

edited

metamaskbot commented May 7, 2024

mcmire commented May 7, 2024

metamaskbot commented May 7, 2024

metamaskbot commented May 7, 2024

mcmire left a comment

metamaskbot commented May 23, 2024

chore: bump assets controllers to latest #24360

chore: bump assets controllers to latest #24360

Conversation

sahar-fehri commented May 3, 2024 • edited by github-actions bot

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented May 3, 2024

socket-security bot commented May 3, 2024 • edited

sahar-fehri commented May 3, 2024

metamaskbot commented May 3, 2024

codecov bot commented May 3, 2024 • edited

Codecov Report

metamaskbot commented May 3, 2024

legobeat commented May 4, 2024 • edited

metamaskbot commented May 6, 2024

sahar-fehri commented May 6, 2024 • edited

metamaskbot commented May 7, 2024

metamaskbot commented May 7, 2024

sahar-fehri commented May 7, 2024

socket-security bot commented May 7, 2024 • edited

metamaskbot commented May 7, 2024

mcmire commented May 7, 2024

metamaskbot commented May 7, 2024

metamaskbot commented May 7, 2024

mcmire left a comment

Choose a reason for hiding this comment

metamaskbot commented May 23, 2024

sahar-fehri commented May 3, 2024 •

edited by github-actions bot

socket-security bot commented May 3, 2024 •

edited

codecov bot commented May 3, 2024 •

edited

legobeat commented May 4, 2024 •

edited

sahar-fehri commented May 6, 2024 •

edited

socket-security bot commented May 7, 2024 •

edited