Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [Snaps E2E] Streamline tests #24358

Merged
merged 11 commits into from May 14, 2024
Merged

test: [Snaps E2E] Streamline tests #24358

merged 11 commits into from May 14, 2024

Conversation

bowensanders
Copy link
Contributor

@bowensanders bowensanders commented May 2, 2024

Description

This makes tweaks to most of the tests to further eliminate issues (flakiness, etc) with the snaps E2Es.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. CI Passes

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bowensanders bowensanders self-assigned this May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (01bac0c) to head (30af695).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24358   +/-   ##
========================================
  Coverage    67.39%   67.39%           
========================================
  Files         1289     1289           
  Lines        50210    50210           
  Branches     13005    13005           
========================================
  Hits         33837    33837           
  Misses       16373    16373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [30af695]
Page Load Metrics (1595 ± 734 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681791083416
domContentLoaded97019147
load55348415951529734
domInteractive97019147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bowensanders bowensanders marked this pull request as ready for review May 14, 2024 18:02
@bowensanders bowensanders requested a review from a team as a code owner May 14, 2024 18:02
@bowensanders bowensanders merged commit 198ba24 into develop May 14, 2024
72 checks passed
@bowensanders bowensanders deleted the bowen/e2eupgrades branch May 14, 2024 18:47
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-snaps release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants