fix: incorrect token balance changes for simulations of multiple tokens that include an NFT mint #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz
approved these changes
May 21, 2024
vinistevam
approved these changes
May 21, 2024
Merged
dbrans
added a commit
that referenced
this pull request
May 21, 2024
## Explanation Patch release of TransactionController with #4290 ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? For example: * Fixes #12345 * Related to #67890 --> * Related to MetaMask/metamask-extension#24586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When simulating a transaction resulting in an NFT mint, we skip the prior owner check for the NFT since the token does not exist yet. However, for subsequent tokens, we were using the incorrect index for the prior balance transaction.
The fix is to keep a separate prevBalanceIndex, which we only increment if a prior balance transaction was included in the simulation.
References
Changelog
@metamask/transaction-controllerChecklist