fix: Mutex never gets released on refresh function of AccountTrackerController #4270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently the mutex do not get released unless there is an error thrown by the
getBalanceFromChain
functionFixed by move the release of the murex to the finally block. It was also removed unnecessary catch block.
Now the mutex gets released when the logic of refresh runs successfully
Fixed
refresh
method would remain locked indefinitely after it was run successfully. The mutex was only released upon failure.References
Changelog
@metamask/assets-controllers
Checklist