Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share button blog #5513

Closed
wants to merge 2 commits into from
Closed

Conversation

ddjerqq
Copy link

@ddjerqq ddjerqq commented May 17, 2024

Added Share button blog

Closes #4022

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • The PR is submitted to the correct branch (master for dev, rel-1.x for maintenance).
  • My code follows the code style of this project.
  • I've added relevant tests.

Copy link
Contributor

github-actions bot commented May 17, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Collaborator

@stsrki stsrki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to mention. Blogs go into current production branch(rel-1.5) so that we can release them without breaking documentation version. I will rebase it now.

@stsrki stsrki changed the base branch from master to rel-1.5 May 18, 2024 05:44
@stsrki stsrki changed the base branch from rel-1.5 to master May 18, 2024 05:44
@stsrki
Copy link
Collaborator

stsrki commented May 18, 2024

It seems rebasing is not an option now. I assume you have created your feature branch from master? It is best to close the PR and recreate it starting from rel-1.5 branch, not the master.

@ddjerqq
Copy link
Author

ddjerqq commented May 19, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request May 19, 2024
@ddjerqq
Copy link
Author

ddjerqq commented May 19, 2024

I forgot to mention. Blogs go into current production branch(rel-1.5) so that we can release them without breaking documentation version. I will rebase it now.

Will consider this for future blogs! Thanks for the heads up!

@stsrki
Copy link
Collaborator

stsrki commented May 19, 2024

I forgot to mention. Blogs go into current production branch(rel-1.5) so that we can release them without breaking documentation version. I will rebase it now.

Will consider this for future blogs! Thanks for the heads up!

It needs to also go now into rel-1.5 since master is only for new development.

I will close the PR and you can open new that targets the right branch.

@stsrki stsrki closed this May 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog: Share Icons
2 participants