Video: play Youtube videos #4963
Conversation
|
So the idea is that the user just enters the id from youtube, the plan is to add an explanation to users where they can find that id and use it to add the desired video |
|
so a youtube video can't be rendered using plyr without the /embed/ part of the link and what comes after the YoutubeVideoID, based on other cases I've found while working on this, I think it's the most optimal, because in this way user can play any video they want from YouTube |
|
therefore, the user can reduce the width and height of the container in which YouTube is located, as for other parameters that are characteristic of the video, YouTube already covers it, I don't know if we should adjust that parameters when user is using youtube video and how can we do that? |
steal4life
changed the title
| ///<summary> | ||
| /// ID of youtube video link. | ||
| /// </summary> | ||
| public string YoutubeVideoID; |
There was a problem hiding this comment.
Should this have the setter as public? Seems like we set this ourselves and should not allow anyone to override it?
There was a problem hiding this comment.
And should we really expose something specific to Youtube like this? Which we don't seem to require to do anything with it, and are adding specific regex logic that could perhaps change with time? i.e youtube changes the way they do ids or something?
| @@ -41,6 +51,7 @@ public override async Task SetParametersAsync( ParameterView parameters ) | |||
| ProtectionHttpRequestHeaders = new { Changed = protectionHttpRequestHeadersChanged, Value = paramProtectionHttpRequestHeaders }, | |||
| CurrentTime = new { Changed = currentTimeChanged, Value = paramCurrentTime }, | |||
| Volume = new { Changed = volumeChanged, Value = paramVolume }, | |||
| YoutubeVideoSource = new { Changed = youtubeVideoSourceChanged, Value = paramYoutubeVideoSource } | |||
There was a problem hiding this comment.
@stsrki @steal4life
So this YoutubeVideoSource is an "option" of the underlying plyr library?
What if we instead added a SourceType enum instead?
SourceType.Default
SourceType.Youtube
and the user still defines the source in the same Source parameter, and we act accordingly to the defined SourceType internally?
Closes #4872