python cleanup for 3.11 #415
Conversation
marksmayo
commented
Jan 23, 2023
marksmayo
commented
- converted strings to f-strings
- sorted imports
- added trailing commas (as per 3.5, 3.6+)
- fixed some docstrings
- fixed spacings
- made some quotes consistent
- converted strings to f-strings - sorted imports - added trailing commas (as per 3.5, 3.6+) - fixed some docstrings - fixed spacings - made some quotes consistent
There was a problem hiding this comment.
I'm normally reluctant to this kind of PR, since it introduces a lot of changes (hence potential Git conflicts) with little added value. But MechanicalSoup is not that active these days, so the probability that another change clashes with this one is low, and we try to be as close as possible to perfection (;-) ) and this patch goes in the right direction.
I didn't have time to make a proper review, though. At least the point raised by Dan needs to be fixed.
| # -- General configuration ------------------------------------------------ | ||
|
|
||
| # If your documentation needs a minimal Sphinx version, state it here. | ||
| #needs_sphinx = '1.0' |
There was a problem hiding this comment.
I disagree with this series of changes. I like the distinction between comments (# like this) and commented-out code (#like = that). No strong opinion, but I'd rather not change things I'm already happy with.
I used isort to sort imports, and flake8/pylint to look for issues. |
