Fix loop getting stuck when launching a process fails on Windows

Fixes amphp#51, amphp#71. Original patch: Nicodinus@3d41ea5
MatmaRex · Feb 27, 2024 · 3bb6784 · 3bb6784
1 parent 04b4517
commit 3bb6784
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/lib/Internal/Windows/SocketConnector.php b/lib/Internal/Windows/SocketConnector.php
@@ -365,6 +365,11 @@ public function onProcessConnectTimeout($watcher, Handle $handle)
  \proc_close($handle->proc);
 
  $handle->joinDeferred->fail($error);
+
+ if ($handle->status === ProcessStatus::STARTING) {
+ Loop::cancel($handle->childPidWatcher);
+ $handle->pidDeferred->fail($error);
+ }
  }
 
  public function registerPendingProcess(Handle $handle)