Merge pull request #694 from if4lcon/4.0

numeric validation rule to accepts floats

src/masonite/validation/Validator.py

@@ -484,10 +484,10 @@ class numeric(BaseValidation):
  def passes(self, attribute, key, dictionary):
  if isinstance(attribute, list):
  for value in attribute:
- if not str(value).isdigit():
+ if not str(value).replace(".", "", 1).isdigit():
  return False
  else:
- return str(attribute).isdigit()
+ return str(attribute).replace(".", "", 1).isdigit()
 
  return True
 

tests/features/validation/test_validation.py

@@ -445,10 +445,18 @@ def test_numeric(self):
 
  self.assertEqual(len(validate), 0)
 
+ validate = Validator().validate({"test": 1.9}, numeric(["test"]))
+
+ self.assertEqual(len(validate), 0)
+
  validate = Validator().validate({"test": "hey"}, numeric(["test"]))
 
  self.assertEqual(validate.all(), {"test": ["The test must be a numeric."]})
 
+ validate = Validator().validate({"test": '1..9'}, numeric(["test"]))
+
+ self.assertEqual(validate.all(), {"test": ["The test must be a numeric."]})
+
  def test_several_tests(self):
  validate = Validator().validate(
  {"test": "hey"}, required(["notin"]), numeric(["notin"])