Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GET_TEXT to GET_TEXT_F #27032

Merged

Conversation

classicrocker883
Copy link
Contributor

Description

Now that some other than English language_*.h files have these defined, we can use GET_TEXT_F instead.

In addition, I included a swap over from MString<> to TS for proui/printstats.cpp because it does save on memory.

Requirements

Benefits

Configurations

Related Issues

@sjasonsmith
Copy link
Contributor

I believe that from @thinkyhead's comment on #26949 that this is probably desirable, but I'm going to leave it to him to merge since the GET_TEXT macros weren't explicitly referenced in that comment. I'm still a bit fuzzy on all the different string types and advantages of each.

I attempted to do a find/replace of ALL the GET_TEXT macros, but still had to revert several files that caused build failures.

I am able to compile all the tests if I add replacements in these files, but it is possible that they are just not covered by the compilation checks:

image

@thinkyhead
Copy link
Member

Thanks for catching these. We can also go straight to the "_P" versions of functions / methods sometimes, if for some (weird) reason using the passthrough increases AVR build size. Ideally we should find that the use of passthroughs has zero impact on build size.

@thinkyhead thinkyhead merged commit 4934871 into MarlinFirmware:bugfix-2.1.x May 6, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants