[2.1.x] 馃悰 Fix bool evalution of XYval and similar types #27026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Input Shaping bootloop among other issues. See MarlinFirmware#26936 for more information. Co-authored-by: sjasonsmith <[email protected]>
This was referenced Apr 28, 2024
thisiskeithb
changed the title
1 task
diego-cr
pushed a commit
to diego-cr/Marlin
that referenced
this pull request
May 7, 2024
Co-authored-by: sjasonsmith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important
This is a
2.1.x-specific patch for board lockup and bootloops with Input Shaping among other things. Originally submitted tobugfix-2.1.xby @sjasonsmith in #26936And if you're asking why this didn't affect
bugfix-2.1.x, it's because:Originally posted by @tombrazier in #26811 (comment)
Verified that board bootloops and lockups are gone on an SKR 1.4 with
INPUT_SHAPING_XandINPUT_SHAPING_Yenabled.Requirements
Marlin
2.1.xBenefits
Marlin
2.1.xwill include this patch on the next release.Related Issues
Related Issues