Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new DWIN_SETs #994

Open
wants to merge 14 commits into
base: import-2.1.x
Choose a base branch
from

Conversation

classicrocker883
Copy link

@classicrocker883 classicrocker883 commented Dec 20, 2023

update README
add support for Voxelab

give user options


see How to update the display wiki at mriscoc's repo.

So apparently there have been updates with using other than DWIN displays.

update README
@thisiskeithb
Copy link
Member

Are these required for the LCD?

image

@thinkyhead
Copy link
Member

thinkyhead commented Dec 21, 2023

This PR is a bit on the indulgent side.

We supply a single display set — DWIN_SET (DWIN) and private (DACAI) — so that this one set can be installed once on the display and then it works with all the UI options included with Marlin for the Ender 3 V2. We maintain the DWIN_SET and private folders just for that purpose, and we aren't hosting these display sets for other projects. We are happy to provide links to display sets that go with other forks of Marlin, but we would rather not take on the maintenance of several display sets if we can avoid it. It was enough trouble just to cobble together one set and get all the UI developers to adopt the changes.

So, please reduce this PR down to just the essentials that allow us to have the prettier icons from ProUI without all the extra display sets and options.

@classicrocker883
Copy link
Author

classicrocker883 commented Dec 22, 2023

Are these required for the LCD?

image

they're not exactly required for the LCD itself. but they are needed for the HAS_GCODE_PREVIEW feature in order to view the model preview. mainly the ".py" file needs to be installed in a users computer files, the ".jpg" are just part of instructions how it needs to be installed for the Slicer

@classicrocker883
Copy link
Author

classicrocker883 commented Dec 22, 2023

So, please reduce this PR down to just the essentials that allow us to have the prettier icons from ProUI without all the extra display sets and options.

ill try to make it as simple as possible, there are just a bunch of options it seems. for instance, the "private" folder inside Custom Display Sets/Creality appears to be an older version of the same "private" inside Custom Display Sets/DACAI. half of these display assets come from Mriscoc's repo. in the README it states

DACAI firmware update

In order to use all the features of this firmware with DACAI screens it has to be updated. If you can't see preview images with this g-code test file update your DACAI screen firmware.

so I'm guessing that we can remove the "private.tar.gz" and "firmware.zlib" files from Creality so it is just the "DWIN_SET".
and the "Icon Packs" from Voxelab because those are just icon images, not needed for anything.

as of now it looks like everything is good to go. not sure what else could be done.

@thinkyhead
Copy link
Member

You can tell by the presence of 9.ICO which DWIN_SET folders pertain to the older CrealityUI. Sets that pertain to our updated CrealityUI / JysersUI / ProUI / MarlinUI contain 3.ICO, 4.ICO, and 7.ICO.

The 9.ICO version of the DWIN_SET is essentially deprecated and requires USE_STOCK_DWIN_SET to be defined in the configuration for CrealityUI to use 9.ICO instead of ours.

Since these sets are obsolete for mainline Marlin, they need to be re-created with three ICO files instead of just one, or these sets can simply be removed.

We have striven to make one set of "Marlin"-branded bitmaps that work with all of our Ender-3 V2 UI options: CrealityUI / MarlinUI / ProUI / JyersUI. We won't continue to support or provide old-style sets, nor do we need to include a number of alternative boot screens with different branding. We kept the Creality boot screen around for the convenience of Creality as we sometimes work more closely with them.

@thinkyhead thinkyhead force-pushed the import-2.1.x branch 5 times, most recently from ef3d7e2 to 7f1571e Compare January 3, 2024 15:41
@thisiskeithb thisiskeithb changed the title Add new DWIN_SET's Add new DWIN_SETs Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants