fix: carousel should stop immediately after interval is set to false

Fix reactstrap#2779

src/Carousel.js

@@ -112,7 +112,12 @@ class Carousel extends React.Component {
  }
 
  componentDidUpdate(prevProps, prevState) {
- if (prevState.activeIndex === this.state.activeIndex) return;
+ if (
+ prevState.activeIndex === this.state.activeIndex &&
+ (prevProps.interval === this.props.interval ||
+ this.props.interval !== false)
+ )
+ return;
  this.setInterval();
  }
 

src/__tests__/Carousel.spec.js

@@ -8,6 +8,7 @@ import CarouselIndicators from '../CarouselIndicators';
 import CarouselControl from '../CarouselControl';
 import CarouselCaption from '../CarouselCaption';
 import { CarouselContext } from '../CarouselContext';
+import { shallow } from 'enzyme';
 
 const DEFAULT_TIMER_TIME = 600;
 
@@ -765,5 +766,23 @@ describe('Carousel', () => {
  jest.advanceTimersByTime(1000);
  expect(next).toHaveBeenCalled();
  });
+
+ it('it should stop immediately when interval is set to false', () => {
+ const next = jest.fn();
+ const wrapper = shallow(
+ <Carousel
+ next={next}
+ previous={() => {}}
+ interval="1000"
+ activeIndex={0}
+ ride="carousel"
+ >
+ {slides}
+ </Carousel>,
+ );
+ wrapper.setProps({ interval: false });
+ jest.advanceTimersByTime(1000);
+ expect(next).not.toHaveBeenCalled();
+ });
  });
 });