MDEV-34129 mariadb-install-db appears to hang on macOS #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
A bug in signal_handler thread initialization led to an overcomplicated implementation of wait_for_signal_handler_to_end, namely that we could fail to initialize the signal handler but mark it as active anyway. This meant that we could wait for it to terminate when it didn't exist in the first place. Additionally, let's immediately close down the signal handler loop when we decide to break connections--it's the start of process termination anyway, and there's no need to wait once we've invoked break_connections.
DaveGosselin-MariaDB
force-pushed
the
10.5-mdev-34129
branch
from
60e2be0
to
45279cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in signal_handler thread initialization led to an overcomplicated implementation of wait_for_signal_handler_to_end, namely that we could fail to initialize the signal handler but mark it as active anyway. This meant that we could wait for it to terminate when it didn't exist in the first place.
Additionally, let's immediately close down the signal handler loop when we decide to break connections--it's the start of process termination anyway, and there's no need to wait once we've invoked break_connections.