Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-34146: Remove duplicate #DEBHELPER# from MariaDB server postrm #3252

Open
wants to merge 1 commit into
base: 10.11
Choose a base branch
from

Conversation

illuusio
Copy link
Contributor

  • The Jira issue number for this PR is: MDEV-34146

Description

Moving to use Debian systemd install and uninstall scripts caused duplicated DEBHELP to server postrm script. Commit removes unneeded and makes postrm work better and pass lintian tests

Release Notes

No notes are needed

How can this PR be tested?

Build DEB packages with debian/deb-autobake.sh and run lintian --display-info --pedantic --allow-root ../*.changes to check if E: mariadb-server: duplicate-updaterc.d-calls-in-postrm mariadb [postrm:86] is not there PR works

or see Salsa-CI run's lintian:
https://salsa.debian.org/illuusio/mariadb-server/-/commit/ce8ff3539d17a661ec67a347b4180abe808c11ff

Basing the PR against the correct MariaDB version

  • This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

Moving to use Debian systemd install and uninstall scripts
caused duplicated DEBHELP to server postrm script. Commit
removes unneeded and makes postrm work better and pass lintian
tests
@illuusio illuusio requested a review from grooverdan May 13, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants