Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenSeaSample and Sample Documentation #2625

Merged
merged 9 commits into from May 20, 2024

Conversation

inforithmics
Copy link
Contributor

@inforithmics inforithmics commented May 9, 2024

Please summarize your PR and explain which problem it solves.

  1. Fixed OpenSea Sample (use another Webservice)
  2. Add Gebco_2021 Sample (the opensea sample used an gebco_2021 Image).
  3. Fixed missing Samples Documentation.

@inforithmics inforithmics changed the title Fix: OpenSeaSample Fix: OpenSeaSample and Sample Documentation May 9, 2024
@pauldendulk
Copy link
Member

Somewhere else I use the open tile service pasted below, did you look into that? It seems to behave fine.

private static HttpTileSource CreateTileSource(string userAgent)
{
    return new HttpTileSource(new GlobalSphericalMercator(),
        "https://tiles.openseamap.org/seamark/{z}/{x}/{y}.png",
        new[] { "a", "b", "c" }, name: "OpenSeaMap",
        userAgent: userAgent, persistentCache: DefaultCache);
}

@inforithmics
Copy link
Contributor Author

Somewhere else I use the open tile service pasted below, did you look into that? It seems to behave fine.

private static HttpTileSource CreateTileSource(string userAgent)
{
    return new HttpTileSource(new GlobalSphericalMercator(),
        "https://tiles.openseamap.org/seamark/{z}/{x}/{y}.png",
        new[] { "a", "b", "c" }, name: "OpenSeaMap",
        userAgent: userAgent, persistentCache: DefaultCache);
}

This shouldn't be a problem the problem was that this service
https://depth.openseamap.org/geoserver/gebco2021/wms disappeared.
So I use now this web service to test opensea.
https://depth.openseamap.org/geoserver/ows

Because the the disappeared service was gebco2021 service I added a gebco 2021 service sample.

@pauldendulk
Copy link
Member

I will merge this if it is green.

@inforithmics
Copy link
Contributor Author

To fix build Uno needs to be updated. Because the Uno GPU Pull request is green and there I upgraded Uno.

@pauldendulk pauldendulk changed the title Fix: OpenSeaSample and Sample Documentation Fix OpenSeaSample and Sample Documentation May 20, 2024
Copy link
Member

@pauldendulk pauldendulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pauldendulk pauldendulk merged commit d4660de into Mapsui:main May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants