Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: to skia 3.0.0-preview.3.1 #2603

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

inforithmics
Copy link
Contributor

@inforithmics inforithmics commented Apr 21, 2024

Updating to Skia 3.0.0 to see where things break.

Is currently a draft until Skia 3.0.0 is a stable Version

Works:

  • Avalonia
  • Maui
  • Maui MapView (Crashes at startup, because Svg.Skia is used to draw symbols)
  • Wpf
  • Uno
  • Blazor
  • WinUI
  • Android
  • iOS
  • Eto

Current Svg doesn't fully work because Skia.Svg needs to be updated to a new Version

Avalonia needs to be Version 11.1 for Skia 3.0.0 support

New Features:

  • UseGPU on Windows
  • UseGPU on Android
  • UseGPU on Mac

It seems possible to target SkiaSharp 2.88.8 and the Users can then themself upgrade to SkiaSharp 3.0.0. But for that
SkiaSharp.Views.Maui.Controls.Compatibility needs to be removed from Maui. (I think this isn't needed anymore).

@inforithmics inforithmics marked this pull request as draft April 21, 2024 12:37
@inforithmics inforithmics changed the title WIP Update: to skia 3.0.0-preview.3.1 Update: to skia 3.0.0-preview.3.1 Apr 21, 2024
@charlenni
Copy link
Member

That is a very good idea.

@charlenni
Copy link
Member

charlenni commented Apr 23, 2024

Isn't there also an Apple Metal control for iOS and Mac OS X, that work in Maui?

@inforithmics
Copy link
Contributor Author

inforithmics commented Apr 27, 2024

Isn't there also an Apple Metal control for iOS and Mac OS X, that work in Maui?

I first thought that a SKMetal Target needs to be introduced, but then I looked at the implementation and saw that on macos (maccataylst) the SkMetal backend is used for Accelerated Rendering so I can simply remove the conditions and it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants