Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether local_path provided by output_file is not absolute, in which case make path relative_to curr-ent directory, otherwise provide user flexibility to specify where media_embed is to be retrieved from, outside of relative path
Overview: What does this pull request change?
added the check at lines 159-161:
This allows the user to retrieve media from outside the project root, for embedding into the .ipynb view
Motivation and Explanation: Why and how do your changes improve the library?
The current state of the ipython_magic.py file does not allow discovering media outside of the project root for embedding into the .ipynb view. The proposed changes addresses this defect.
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist