Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TACO Interface #77

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

TACO Interface #77

wants to merge 37 commits into from

Conversation

jackaraz
Copy link
Member

@jackaraz jackaraz commented May 6, 2022 •
edited

Context:
This implementation enables the TACO interface for region combination.

Description of the Change:

  • A new database for the recast interface has been formed.
  • Separate database has been introduced for the TACO interface

Benefits:
This will allow uncorrelated signal regions to be combined.

TODO

  • Integrare TACO interface to recasting interface.
  • Integrate region combination functionality from SModelS to MadAnalysis
  • Eliminate pyhf dependence.

@jackaraz jackaraz added ⚙️enhancement New feature or request PAD Public Analysis Database labels May 6, 2022
@jackaraz jackaraz requested a review from BFuks May 6, 2022 16:14
@github-actions
Copy link

github-actions bot commented May 6, 2022

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

jackaraz added 25 commits May 9, 2022 13:58
@jackaraz
correction on upper limit calculation
461b66e
@jackaraz
extend the test module of taco_interface.py
c877d0e
@jackaraz
add bests
3cd9ef0
@jackaraz
update simplified_likelihood.py according to recent updates in SModel…
5cc6213 
…S: see combo_fixes branch
@jackaraz
update to the current status of simplified_likelihood.py
b5f531b
@jackaraz
s95exp reversed and test on CLs calculation have been added.
ccf6147
@jackaraz
extend test
62bf0c8
@jackaraz
update CLs calculation
42824f1
@jackaraz
update simplified_likelihood.py
f49d39a
@jackaraz
Merge branch 'main' into taco_interface
ba7b179
@jackaraz
fix CLs calculation issue
1fed771
@jackaraz
initiate pyhf interface
3ec8a32
@jackaraz
finalize pyhf_interface.py
967bf53
@jackaraz
update run_recast.py with new pyhf interface
106e481
@jackaraz
fix relative import
b5727e6
@jackaraz
fix relative import
103bd3d
@jackaraz
match simplified_likelihood.py
6832e17
@jackaraz
adapt new pyhf_interface.py: bugfixes
0d1460d
@jackaraz
add an abstract method for taco interface
f3e47e1
@jackaraz
add upper limit calculation for POI
1bde071
@jackaraz
initialize TACO with pyhf backend
5cf4311
@jackaraz
update pyhf_interface.py
0a024c1
@jackaraz
fix TACO writer
0fe62c1
@jackaraz
update code style
823287c
@jackaraz
bugfix in run_recast.py
971f21f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BFuks BFuks Awaiting requested review from BFuks

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
⚙️enhancement New feature or request PAD Public Analysis Database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jackaraz