Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed string conversion error #34

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Fixed string conversion error #34

merged 1 commit into from
Jun 17, 2023

Conversation

Macoron
Copy link
Owner

@Macoron Macoron commented Jun 17, 2023

In some rare cases, whisper could output strings that would result this error:

ExecutionEngineException: String conversion error: Partial byte sequence encountered in the input.

Reproduced this by transcribing churchill.wav with Chinese output language. Looks like Marshal.PtrToStringAnsi worked incorrectly, so I replaced it with custom method.

@Macoron Macoron merged commit 7484284 into master Jun 17, 2023
4 checks passed
@Macoron Macoron deleted the fix-uni branch June 17, 2023 19:25
github-actions bot pushed a commit to GameWorkstore/whisper.unity that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant