Add prompting support #25
Conversation
|
Wow, amazing job! For updating builded libraries, no worries - I will do it myself. While 1.3.0 is still considered to be beta, it's probably already stable. I will do some tests and update builded libraries in another PR. After this we can merge it in your PR. |
|
Small update from my side. I added new Github workflow to build binaries (read #27 for more details). Next I need to bump whisper.cpp version and test it on different platforms. |
|
Alright, I updated whisper.cpp to 1.4.2. Could you merge latest master into your branch? After that we can do proper review and merge your PR. |
|
|
||
| [Tooltip("Initial prompt as a string variable. " + | ||
| "It should improve transcription quality or guide it to the right direction.")] | ||
| public string initialPrompt; |
There was a problem hiding this comment.
Add [TextArea] attribute. This will make changing it in inspector much easier.
| new InitialPrompt | ||
| { | ||
| name = "UPPERCASE", | ||
| prompt = "EVERY WORD IS WRITTEN IN CAPITAL LETTERS AS IF THE CAPS LOCK KEY WAS PRESSED", |
There was a problem hiding this comment.
This prompt for some reason doesn't work for me, but this one does.
"HELLO HOW IS IT GOING ALWAYS USE UPPERCASE NO PUNCTUATION GOODBYE ONE TWO THREE START STOP I YOU ME THEY"
|
|
||
| namespace Whisper.Samples | ||
| { | ||
| public class InitialPromptDemo : MonoBehaviour |
There was a problem hiding this comment.
Could you move this in first demo? Right now there are already a lot of scenes and it's hard to test and maintain them.
Macoron
changed the title
* Add prompting support Macoron#8 (upd to 1.3.0) * fix C# 9 target-typed new (for Unity 2019/2020) * fixes (Macoron#25)
whisper.cppto version1.3.0(first release after1.2.1that includes theconst char * initial_promptparameter)byte* initial_promptparameter following the analogy of thebyte* languageparameterwhisper_state_ptrparameter to thewhisper_new_segment_callbackdelegate to ensure correct marshalling (whisper.cpp commit)void* progress_callbackcallback to theWhisperNativeParamsstruct to ensure correct marshalling (whisper.cpp commit)1.3.0version ofwhisper.cppfor Linux and Windows. However, still need library builds for MacOS, iOS and Android. I couldn't build them as I don't have MacOS, so I would appreciate your help with that.5 - Initial Promptsample to demonstrate how theinitial_promptparameter worksinitial_promptparameter marshals correctly, and the resulting text changes due to prompting