Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Cases for MultiPitchKlapuri and MultiPitchMelodia #1141

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cvf-bcn-gituser
Copy link
Contributor

Similar to PR 1137
#1137
Extending test coverage to consider multipitch algorithms.

@cvf-bcn-gituser cvf-bcn-gituser marked this pull request as draft April 19, 2021 15:53
@cvf-bcn-gituser
Copy link
Contributor Author

@dbogdanov , updated to add melodia. this algorithm has a very similar i/o. It is the monophonic pre-decessor of Kalpuri.
Still in draft mode but comments welcome.

@cvf-bcn-gituser
Copy link
Contributor Author

There is a FIXME in the Unit Tests where a crash occurs.
The origin of the DIV by zero error is not in pitchmelodia.cpp. Its origin is "PSF" algorithm chain.
This is being dealt with in PR # 1142.

@cvf-bcn-gituser cvf-bcn-gituser marked this pull request as ready for review May 24, 2021 14:45
@cvf-bcn-gituser cvf-bcn-gituser marked this pull request as draft June 11, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant